Stabilize Windows trusted signing setup - #84
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
badcuban
marked this pull request as ready for review
July 23, 2026 05:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
TrustedSigningPowerShell module to 0.5.8PSModulePathforelectron-builderchild processesInvoke-TrustedSigningresolvesWhy
Nightly release run 29979882247 failed in the Windows installer job after
electron-builderinstalledTrustedSigningin one PowerShell process but could not resolveInvoke-TrustedSigningin the signing process. macOS, Linux, release smoke, and release preparation succeeded.This preserves mandatory Authenticode signing while removing PowerShell module discovery from the critical packaging path.
Validation
vp fmtvp lintvp run typecheckvp run release:smokegit diff --check